Skip to content

OCPBUGS-78542: Remove useHistory and replace with useNavigate#364

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
logonoff:OCPBUGS-78542
Mar 16, 2026
Merged

OCPBUGS-78542: Remove useHistory and replace with useNavigate#364
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
logonoff:OCPBUGS-78542

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Mar 16, 2026

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 94fe8672-4983-414c-92cd-dbdda0d23c31

📥 Commits

Reviewing files that changed from the base of the PR and between 97f0b8d and 57cf496.

📒 Files selected for processing (2)
  • src/views/routes/actions/hooks/useRouteActions.ts
  • src/views/services/actions/hooks/useServiceActions.tsx

Walkthrough

This pull request replaces the useHistory hook with useNavigate from react-router-dom v5 compatibility layer across two action hook files. Navigation calls are updated from history.push() to navigate() syntax. No public API signatures or functional behaviors are altered.

Changes

Cohort / File(s) Summary
Navigation Hook Refactoring
src/views/routes/actions/hooks/useRouteActions.ts, src/views/services/actions/hooks/useServiceActions.tsx		 Replaced useHistory import with useNavigate from react-router-dom v5 compatibility. Updated navigation calls from history.push() to navigate() in Route and Service edit actions. No API signature changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 16, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 16, 2026

@logonoff: This pull request references Jira Issue OCPBUGS-78542, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from adamviktora and gouyang March 16, 2026 16:09
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2026
@upalatucci
Copy link
Contributor

upalatucci commented Mar 16, 2026

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 16, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2026

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f9c8030 into openshift:main Mar 16, 2026
6 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 16, 2026

@logonoff: Jira Issue OCPBUGS-78542: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-78542 has not been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff deleted the OCPBUGS-78542 branch March 16, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@upalatucci upalatucci upalatucci approved these changes

@adamviktora adamviktora Awaiting requested review from adamviktora

@gouyang gouyang Awaiting requested review from gouyang

Assignees

@upalatucci upalatucci

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@logonoff @openshift-ci-robot @upalatucci